Msbuild tasks. #5
Draft
+115
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I finish wrapping up https://github.com/Kuinox/Myna and i'll get back to this PR and then release the packages. |
|
Take your time. I'll be busy with other things for a week or two. |
joshudson
reviewed
Oct 19, 2024
| /// <summary> | ||
| /// The last write time to sets. Default to 2000-01-01. | ||
| /// </summary> | ||
| public DateTime LastWriteTime { get; set; } = new DateTime(2000, 1, 1); |
There was a problem hiding this comment.
I don't know which PR gets in first, but this creates a semantic merge conflict between them. SOURCE_DATE_EPOCH should clearly be used in the initializer here too.
There was a problem hiding this comment.
https://learn.microsoft.com/en-us/dotnet/api/system.datetime.unixepoch?view=net6.0
For later reference, UnixEpoch is pre-defined at this location in the .NET 6 API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2.
@BinToss, I think I will create a regular Msbuild task that do nothing, and have another package that magically make the nuget reproducible, so if anyone want to use the task directly, they can.